@andrueastman I'm running out of time on this one but I thinks it irons out the last allOf scenarios. If you can review and test, I'd appreciate it. Otherwise I'll pick it up when I get back.

I queued a generation build for sanity.

https://microsoftgraph.visualstudio.com/Graph%20Developer%20Experiences/_build/results?buildId=150597&view=results

Generation is identical for Microsoft Graph scenarios! microsoftgraph/msgraph-sdk-dotnet#2517

Quality Gate failed

Failed conditions
63.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Validated with https://dev.azure.com/microsoftgraph/Graph%20Developer%20Experiences/_build/results?buildId=150942&view=results . No diff with latest generation on beta/v1

Since commit 448af8f (which is the first of this pull request) I see a lot of warnings about discriminator not being inherited when generating my client. For example:

Discriminator SObjectRootInfo is not inherited from SObjectRootInfo.

The generated code is identical, only the warnings are new.

This problem can be reproduced by debugging the AddsDiscriminatorMappingsAllOfImplicit test and setting a breakpoint on logger.LogWarning("Discriminator {ComponentKey} is not inherited from {ClassName}.", componentKey, baseClass.Name); in the KiotaBuilder.cs file.

Thanks for this @0xced. Any chance you can create a new issue with the input openApi document to help investigate?

There's already at least one in the tests where the problem can be reproduced. I edited my previous message after posting it when I figured out that running the AddsDiscriminatorMappingsAllOfImplicit test was reproducing the issue.

Following this up via #4761